Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: pgadmin: refactor #12604

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

4d62
Copy link
Contributor

@4d62 4d62 commented Jan 9, 2025

sdko/integrations/pgadmin/refactor

@tanberry yeehaw 🤠

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

4d62 added 2 commits January 8, 2025 20:19
Refactors the pgAdmin integration documentation, makes it match existing style guide, and adds subsection for configuration for containerized deployments
Lints refactored documentation page
@4d62 4d62 requested a review from a team as a code owner January 9, 2025 01:23
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 7627b5d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6785796eba147f000881c215

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 7627b5d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6785796e8ffe050008cb32f6
😎 Deploy Preview https://deploy-preview-12604--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.71%. Comparing base (baf8f18) to head (7627b5d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12604      +/-   ##
==========================================
- Coverage   92.75%   92.71%   -0.05%     
==========================================
  Files         769      769              
  Lines       38866    38866              
==========================================
- Hits        36049    36033      -16     
- Misses       2817     2833      +16     
Flag Coverage Δ
e2e 48.57% <ø> (-0.03%) ⬇️
integration 24.64% <ø> (ø)
unit 90.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

4d62 and others added 4 commits January 9, 2025 18:43
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <git@sdko.org>
Adds back "based on" note with updated versions
Adds configuration validation step. Log out, log back in with authentik. Button on login page
@4d62 4d62 requested a review from tanberry January 10, 2025 02:51
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I rather do like your short-and-sweet instructions for the Wizard. (This integration is a lot less complex than other one, with 4 pairs.)

4d62 added 3 commits January 10, 2025 21:41
Fixes incorrect redirect uri introduced during refactor. Probably forgot to copy slug or something. Important thing is that it's fixed

Signed-off-by: 4d62 <git@sdko.org>
@4d62
Copy link
Contributor Author

4d62 commented Jan 13, 2025

friendly ping @tanberry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants